net: isolate the protocol-agnostic part of CConnman::AcceptConnection()
ClosedPublic
Actions

Authored by PiRK on Feb 8 2022, 14:39.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfb406d6140c1: net: isolate the protocol-agnostic part of CConnman::AcceptConnection()

Summary

Isolate the second half of CConnman::AcceptConnection() into a new
separate method, which could be reused if we accept incoming connections
by other means than accept() (first half of
CConnman::AcceptConnection()).

This is a backport of core#20685 [6/20]
https://github.com/bitcoin/bitcoin/pull/20685/commits/7c224fdac4699a2c4953b33ab423f9cddbf95cf7

Depends on D11014

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 8 2022, 14:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2022, 14:39

PiRK requested review of this revision.Feb 8 2022, 14:39

teamcity edited the summary of this revision. (Show Details)Feb 8 2022, 14:40

PiRK added a child revision: D11016: net: avoid unnecessary GetBindAddress() call.Feb 8 2022, 14:40

PiRK edited the summary of this revision. (Show Details)Feb 8 2022, 14:49

Harbormaster completed remote builds in B18199: Diff 32276.Feb 8 2022, 15:08

Fabien accepted this revision.Feb 8 2022, 19:35

This revision is now accepted and ready to land.Feb 8 2022, 19:35

Closed by commit rABCfb406d6140c1: net: isolate the protocol-agnostic part of CConnman::AcceptConnection() (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyFeb 10 2022, 09:15

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfb406d6140c1: net: isolate the protocol-agnostic part of CConnman::AcceptConnection().

Revision Contents
Changeset List

Path

Size

src/

net.h

14 lines

net.cpp

13 lines

Diff 32316

View Options

src/net.h