net: avoid unnecessary GetBindAddress() call
ClosedPublic
Actions

Authored by PiRK on Feb 8 2022, 14:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1e55ff33b8be: net: avoid unnecessary GetBindAddress() call

Summary

Our local (bind) address is already saved in CNode::addrBind and there
is no need to re-retrieve it again with GetBindAddress().

Also, for I2P connections CNode::addrBind would contain our I2P
address, but GetBindAddress() would return something like
127.0.0.1:RANDOM_PORT.

This is a backport of core#20685 [7/20]
https://github.com/bitcoin/bitcoin/pull/20685/commits/f6c267db3be2d7077fd2bdbd34860eba838dea99

Depends on D11015

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 8 2022, 14:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2022, 14:40

PiRK requested review of this revision.Feb 8 2022, 14:40

teamcity edited the summary of this revision. (Show Details)Feb 8 2022, 14:41

PiRK added a child revision: D11017: net: extend CNetAddr::SetSpecial() to support I2P.Feb 8 2022, 14:44

PiRK edited the summary of this revision. (Show Details)Feb 8 2022, 14:49

Harbormaster completed remote builds in B18200: Diff 32277.Feb 8 2022, 15:13

Fabien accepted this revision.Feb 8 2022, 20:29

This revision is now accepted and ready to land.Feb 8 2022, 20:29

Closed by commit rABC1e55ff33b8be: net: avoid unnecessary GetBindAddress() call (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyFeb 10 2022, 09:15

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1e55ff33b8be: net: avoid unnecessary GetBindAddress() call.

Revision Contents
Changeset List

Path

Size

src/

net.cpp

4 lines

Diff 32317

View Options

net: avoid unnecessary GetBindAddress() callClosedPublicActions