Page MenuHomePhabricator
Differential D11022

net: extend Sock::Wait() to report a timeout
ClosedPublic
Actions

Authored by PiRK on Feb 9 2022, 08:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc1e9bd74019c: net: extend Sock::Wait() to report a timeout
Summary

Previously Sock::Wait() would not have signaled to the caller whether a timeout or one of the requested events occurred since that was not needed by any of the callers.

Such functionality will be needed in the I2P implementation, thus extend the Sock::Wait() method.

This is a backport of core#20685 [11/20]
https://github.com/bitcoin/bitcoin/pull/20685/commits/ea1845315a109eb105113cb5fbb6f869e1cf010c

Depends on D11019

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 9 2022, 08:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2022, 08:59
PiRK requested review of this revision.Feb 9 2022, 08:59
PiRK edited the summary of this revision. (Show Details)Feb 9 2022, 09:00
PiRK added a parent revision: D11019: net: dedup MSG_NOSIGNAL and MSG_DONTWAIT definitions.
PiRK added a child revision: D11023: net: extend Sock with methods for robust send & read until terminator.Feb 9 2022, 09:02
teamcity edited the summary of this revision. (Show Details)Feb 9 2022, 09:02
Harbormaster completed remote builds in B18214: Diff 32296.Feb 9 2022, 09:37
Fabien accepted this revision.Feb 9 2022, 11:46
This revision is now accepted and ready to land.Feb 9 2022, 11:46
PiRK updated this revision to Diff 32321.Feb 10 2022, 10:24

rebase

Harbormaster completed remote builds in B18228: Diff 32321.Feb 10 2022, 10:41
Closed by commit rABCc1e9bd74019c: net: extend Sock::Wait() to report a timeout (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyFeb 11 2022, 08:06
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc1e9bd74019c: net: extend Sock::Wait() to report a timeout.

Revision Contents
Changeset List

PathSize
src/
util/
7 lines
37 lines

Diff 32345

View Options

src/util/sock.h

Loading...
View Options

src/util/sock.cpp

Loading...