Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards…
79943feda175
Actions

Description

Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations.

Summary: Fixes phabricator issue T56

Test Plan: make check on Ubuntu 14.04 / 14.05 (Travis equivalent)

Reviewers: #bitcoin_abc, deadalnix, freetrader, sickpig, kyuupichan, awemany, O1 Bitcoin ABC

Reviewed By: #bitcoin_abc, deadalnix, O1 Bitcoin ABC

Differential Revision: https://reviews.bitcoinabc.org/D290

Details

Provenance

CCulianu	Authored on Jul 2 2017, 10:16
CCulianu	Pushed on Jul 3 2017, 09:19

Reviewer

Restricted Project

Differential Revision

D290: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations.

Parents

rABCe0ec90e662e6: Align UAHF spec with upstream Bitcoin-UAHF

Branches

Unknown

Tags

Unknown

Event Timeline

CCulianu committed rABC79943feda175: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards… (authored by CCulianu).Jul 2 2017, 13:14

deadalnix mentioned this in D291: Use raw string comparison instead of std::regex , as it is clearly not mature..Jul 3 2017, 11:25

Changes (1)

Path

Size

src/

test/

net_tests.cpp

rABC79943feda175

View Options