HomePhabricator

Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag

Description

Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag

Summary:
This flag is unused since D6101

Port of BCHN MR#748

As remarked in its definition it is now a meaningless flag
now that sigchecks upgrade is complete (and sigops no longer
exist).

(Historically this flag was used to enable the opcode, then
after the CDS upgrade it became a control on the sigops counting
only. Now after sigchecks it is meaningless.)

Test Plan:
git grep SCRIPT_VERIFY_CHECKDATASIG_SIGOPS
ninja check
Did IBD, checked that blockchain synced to same block as public explorers.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11102

Details

Provenance
Mark Lundeberg <5505128-markblundeberg@users.noreply.gitlab.com>Authored on Aug 24 2020, 23:44
MengerianCommitted on Feb 24 2022, 18:18
MengerianPushed on Feb 24 2022, 18:18
Reviewer
Restricted Project
Differential Revision
D11102: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag
Parents
rABC6dcd3c38df1e: Bump to clang-11 and clang-format-11
Branches
Unknown
Tags
Unknown

Event Timeline