Page MenuHomePhabricator
Differential D6101

Do not count sigops at all anymore
ClosedPublic
Actions

Authored by deadalnix on May 16 2020, 01:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGf5207273e131: Do not count sigops at all anymore
rABCf5207273e131: Do not count sigops at all anymore
Summary

Post upgrade cleanup, get rid of a metric ton of test for obsolete behavior.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 16 2020, 01:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2020, 01:43
deadalnix requested review of this revision.May 16 2020, 01:43
teamcity added a comment.May 16 2020, 01:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 16 2020, 01:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 16 2020, 01:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 16 2020, 01:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 16 2020, 01:49

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

deadalnix updated this revision to Diff 20139.May 16 2020, 01:56

rebase

teamcity added a comment.May 16 2020, 01:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10802: Diff 20136.May 16 2020, 01:56
teamcity added a comment.May 16 2020, 01:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 16 2020, 02:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 16 2020, 02:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 16 2020, 02:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 16 2020, 02:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 16 2020, 02:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10803: Diff 20139.May 16 2020, 02:17
deadalnix added a child revision: D6105: Kill GetSigOpCount.May 16 2020, 18:26
Fabien accepted this revision.May 18 2020, 12:08
This revision is now accepted and ready to land.May 18 2020, 12:08
Closed by commit rABCf5207273e131: Do not count sigops at all anymore (authored by deadalnix). · Explain WhyMay 18 2020, 13:00
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf5207273e131: Do not count sigops at all anymore.
deadalnix added a commit: rSTAGINGf5207273e131: Do not count sigops at all anymore.
PiRK mentioned this in D7902: [backport#16363] test: Add test for BIP30 duplicate tx.Oct 13 2020, 10:55
PiRK mentioned this in rABC2e27aa637254: [backport#16363] test: Add test for BIP30 duplicate tx.Oct 13 2020, 15:06
jasonbcox mentioned this in D9355: Cleanup invalid inputs in p2sh test.Mar 27 2021, 17:24
jasonbcox mentioned this in rABC6ab7261e6537: Cleanup invalid inputs in p2sh test.Mar 28 2021, 21:48
Mengerian mentioned this in D11102: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag.Feb 23 2022, 18:42
Mengerian mentioned this in rABC799f5cedc009: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag.Feb 24 2022, 18:18

Revision Contents
Changeset List

Diff 20187

View Options

src/Makefile.test.include

Loading...
View Options

src/script/script.cpp

Loading...
View Options

src/script/script_flags.h

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/script_p2sh_tests.cpp

Loading...
View Options

src/test/sigopcount_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-mempool-accept-txn.py

Loading...
View Options

test/functional/abc-sigops-deactivation.py

Loading...
View Options

test/functional/abc-sigops-mempool-mining.py

Loading...
View Options

test/functional/abc_p2p_fullblocktest_sigops.py

Loading...
View Options

test/functional/feature_block_sigops.py

Loading...
View Options

test/functional/test_runner.py

Loading...