Page MenuHomePhabricator
Differential D6105

Kill GetSigOpCount
ClosedPublic
Actions

Authored by deadalnix on May 16 2020, 18:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING19a1846f2e5c: Kill GetSigOpCount
rABC19a1846f2e5c: Kill GetSigOpCount
Summary

It now always returns 0, so it's going away.

Depends on D6101

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 16 2020, 18:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2020, 18:26
deadalnix requested review of this revision.May 16 2020, 18:26
teamcity added a comment.May 16 2020, 18:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 16 2020, 18:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 16 2020, 18:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 16 2020, 18:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 16 2020, 18:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

deadalnix added a child revision: D6106: Remove legacy sigops support from miner.May 16 2020, 18:38
teamcity added a comment.May 16 2020, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10809: Diff 20173.May 16 2020, 18:45
Fabien accepted this revision.May 18 2020, 12:10
This revision is now accepted and ready to land.May 18 2020, 12:10
Closed by commit rABC19a1846f2e5c: Kill GetSigOpCount (authored by deadalnix). · Explain WhyMay 18 2020, 13:06
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC19a1846f2e5c: Kill GetSigOpCount.
deadalnix added a commit: rSTAGING19a1846f2e5c: Kill GetSigOpCount.May 18 2020, 13:10
jasonbcox mentioned this in D9355: Cleanup invalid inputs in p2sh test.Mar 27 2021, 17:24
jasonbcox mentioned this in rABC6ab7261e6537: Cleanup invalid inputs in p2sh test.Mar 28 2021, 21:48

Revision Contents
Changeset List

PathSize
src/
consensus/
23 lines
policy/
4 lines
5 lines
script/
14 lines
30 lines
test/
28 lines

Diff 20189

View Options

src/consensus/tx_verify.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/script/script.h

Loading...
View Options

src/script/script.cpp

Loading...
View Options

src/test/script_p2sh_tests.cpp

Loading...