Page MenuHomePhabricator

[backport#16363] test: Add test for BIP30 duplicate tx
ClosedPublic

Authored by PiRK on Tue, Oct 13, 10:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC2e27aa637254: [backport#16363] test: Add test for BIP30 duplicate tx
Summary

This adds a test for BIP30 to check that duplicate txs can exist in the blockchain given the first one was completely spent when the second one is added.

Note that some lines modified in the Core PR were moved and deleted on our side (D5060, D6101)

This concludes backport of Core PR16363
Commit: fa8489a15511f61a372473927e73c34692bbec23
Depends on D7901

Test Plan

ninja && ./test/functional/test_runner.py feature_block

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Tue, Oct 13, 10:55
PiRK requested review of this revision.Tue, Oct 13, 10:55
PiRK retitled this revision from test: Add test for BIP30 duplicate tx to [backport#16363] test: Add test for BIP30 duplicate tx.Tue, Oct 13, 10:56
PiRK edited the summary of this revision. (Show Details)
deadalnix requested changes to this revision.Tue, Oct 13, 13:32
deadalnix added a subscriber: deadalnix.

Provide a link to the commit.

This revision now requires changes to proceed.Tue, Oct 13, 13:32
PiRK requested review of this revision.Tue, Oct 13, 13:51

Link to the commit added to revision.

This revision is now accepted and ready to land.Tue, Oct 13, 14:18