Page MenuHomePhabricator

split feature_block test into sigops and non-sigops parts
ClosedPublic

Authored by markblundeberg on Jan 24 2020, 12:23.

Details

Summary

feature_block.py tests a lot of quirky and fun cases of sigops
counting and sigops limiting. Since sigops is going to be
removed, it makes sense to separate out the tests so that
feature_block can keep running independent of upgrade, and
the sigops tests can be specialized to run depending on
upgrade.

I've left placeholder blocks in place of the sigops tests.
This is because feature_block.py relies on the chain being
built and blocks being matured in a particular order, and
if we outright skip some blocks we may get unmatured
coinbase problems, perhaps not now but definitely possible
in future if some more things are added / backported into
this test.

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix requested changes to this revision.Jan 25 2020, 13:17

I think this is okay because the sigops part is likely to change quite a bit soon, however, please make sure people can find the moved code when they backport.

test/functional/feature_block.py
324 ↗(On Diff #15769)

Put a comment to send people to the right place when they backport.

This revision now requires changes to proceed.Jan 25 2020, 13:17
This revision is now accepted and ready to land.Jan 27 2020, 01:03
markblundeberg added a task: Restricted Maniphest Task.Jan 27 2020, 04:31