Page MenuHomePhabricator
Differential D7901

[backport#16363] test: Properly serialize BIP34 coinbase height
ClosedPublic
Actions

Authored by PiRK on Oct 13 2020, 09:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC8a6204742c0c: [backport#16363] test: Properly serialize BIP34 coinbase height
Summary

In addition to the original commit, I had to add from .script import OP_1, which was skipped in our backport of PR11796 (D5750)

Partial backport of PR16363
Commit 77770d95e2838d7665fa8f621e9e83d79f9b3196

Test Plan

ninja && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 13 2020, 09:42
Owners added a reviewer: Restricted Owners Package.Oct 13 2020, 09:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2020, 09:42
PiRK requested review of this revision.Oct 13 2020, 09:43
teamcity edited the summary of this revision. (Show Details)Oct 13 2020, 09:43
PiRK edited the summary of this revision. (Show Details)Oct 13 2020, 09:48
Harbormaster completed remote builds in B13375: Diff 24586.Oct 13 2020, 09:54
PiRK added a child revision: D7902: [backport#16363] test: Add test for BIP30 duplicate tx.Oct 13 2020, 10:56
deadalnix requested changes to this revision.Oct 13 2020, 13:33
deadalnix added a subscriber: deadalnix.

Please link to the commit.

This revision now requires changes to proceed.Oct 13 2020, 13:33
PiRK requested review of this revision.Oct 13 2020, 13:49
PiRK edited the summary of this revision. (Show Details)

Link to the commit added to revision.

deadalnix accepted this revision.Oct 13 2020, 14:14
deadalnix added inline comments.
test/functional/test_framework/blocktools.py
66 ↗(On Diff #24586)

You can use OP_TRUE here.

This revision is now accepted and ready to land.Oct 13 2020, 14:14
Closed by commit rABC8a6204742c0c: [backport#16363] test: Properly serialize BIP34 coinbase height (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 13 2020, 14:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8a6204742c0c: [backport#16363] test: Properly serialize BIP34 coinbase height.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
28 lines

Diff 24592

View Options

test/functional/test_framework/blocktools.py

Loading...