Page MenuHomePhabricator

[backport#16363] test: Properly serialize BIP34 coinbase height
ClosedPublic

Authored by PiRK on Tue, Oct 13, 09:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC8a6204742c0c: [backport#16363] test: Properly serialize BIP34 coinbase height
Summary

In addition to the original commit, I had to add from .script import OP_1, which was skipped in our backport of PR11796 (D5750)

Partial backport of PR16363
Commit 77770d95e2838d7665fa8f621e9e83d79f9b3196

Test Plan

ninja && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Owners added a reviewer: Restricted Owners Package.Tue, Oct 13, 09:42
PiRK requested review of this revision.Tue, Oct 13, 09:43
deadalnix requested changes to this revision.Tue, Oct 13, 13:33
deadalnix added a subscriber: deadalnix.

Please link to the commit.

This revision now requires changes to proceed.Tue, Oct 13, 13:33
PiRK requested review of this revision.Tue, Oct 13, 13:49
PiRK edited the summary of this revision. (Show Details)

Link to the commit added to revision.

deadalnix added inline comments.
test/functional/test_framework/blocktools.py
66 ↗(On Diff #24586)

You can use OP_TRUE here.

This revision is now accepted and ready to land.Tue, Oct 13, 14:14