HomePhabricator

walletdb: Don't remove database transaction logs and instead error

Description

walletdb: Don't remove database transaction logs and instead error

Summary:
Instead of removing the database transaction logs and retrying the
wallet loading, just return an error message to the user. Additionally,
specifically for DB_RUNRECOVERY, notify the user that this could be due
to different BDB versions. This error is pretty much only caused by
compiling with a newer version of BDB and then trying to open the wallet
with a version compiled with an older version of BDB.

This is a backport of core#18907

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9640

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on May 7 2020, 18:30
PiRKCommitted on Jun 8 2021, 08:04
PiRKPushed on Jun 8 2021, 08:04
Reviewer
Restricted Project
Differential Revision
D9640: walletdb: Don't remove database transaction logs and instead error
Parents
rABC11d97206b17a: Call RecoverDatabaseFile directly from wallettool
Branches
Unknown
Tags
Unknown