HomePhabricator

Call RecoverDatabaseFile directly from wallettool

Description

Call RecoverDatabaseFile directly from wallettool

Summary:
When using the salvage command, call RecoverDatabaseFile directly
instead of SalvageWallet. Also removes SalvageWallet as it is no longer
needed.

SalvageWallet was doing an additional verify on the database which would
cause the salvage to sometimes fail. This is not needed.

This is a backport of core#19457 [1/3]
https://github.com/bitcoin/bitcoin/pull/19457/commits/06e263a4e368671ebb4e4a77c1447ebd5104a488

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9639

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Jul 6 2020, 18:32
PiRKCommitted on Jun 8 2021, 08:00
PiRKPushed on Jun 8 2021, 08:00
Reviewer
Restricted Project
Differential Revision
D9639: Call RecoverDatabaseFile directly from wallettool
Parents
rABC8a9f470950c1: [refactor] deduplicate AmountFromValue
Branches
Unknown
Tags
Unknown