Page MenuHomePhabricator

Call RecoverDatabaseFile directly from wallettool
ClosedPublic

Authored by PiRK on Mon, Jun 7, 07:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC11d97206b17a: Call RecoverDatabaseFile directly from wallettool
Summary

When using the salvage command, call RecoverDatabaseFile directly
instead of SalvageWallet. Also removes SalvageWallet as it is no longer
needed.

SalvageWallet was doing an additional verify on the database which would
cause the salvage to sometimes fail. This is not needed.

This is a backport of core#19457 [1/3]
https://github.com/bitcoin/bitcoin/pull/19457/commits/06e263a4e368671ebb4e4a77c1447ebd5104a488

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, Jun 7, 07:49

Tail of the build log:

[386/445] bitcoin: testing script_commitment_tests
[387/445] Running utility command for check-bitcoin-scheduler_tests
[388/445] Running utility command for check-bitcoin-finalization_tests
[389/445] Running utility command for check-bitcoin-script_commitment_tests
[390/445] bitcoin: testing bip32_tests
[391/445] Running utility command for check-bitcoin-bip32_tests
[392/445] bitcoin: testing sync_tests
[393/445] bitcoin: testing torcontrol_tests
[394/445] Running utility command for check-bitcoin-sync_tests
[395/445] Running utility command for check-bitcoin-torcontrol_tests
[396/445] bitcoin: testing txvalidationcache_tests
[397/445] Running utility command for check-bitcoin-txvalidationcache_tests
[398/445] bitcoin: testing wallet_tests
[399/445] bitcoin: testing timedata_tests
[400/445] bitcoin: testing streams_tests
[401/445] Running utility command for check-bitcoin-wallet_tests
[402/445] Running utility command for check-bitcoin-timedata_tests
[403/445] Running utility command for check-bitcoin-streams_tests
[404/445] bitcoin: testing validation_flush_tests
[405/445] bitcoin: testing compilerbug_tests
[406/445] Running utility command for check-bitcoin-validation_flush_tests
[407/445] Running utility command for check-bitcoin-compilerbug_tests
[408/445] bitcoin: testing checkpoints_tests
[409/445] Running utility command for check-bitcoin-checkpoints_tests
[410/445] bitcoin: testing radix_tests
[411/445] bitcoin: testing blockcheck_tests
[412/445] bitcoin: testing op_reversebytes_tests
[413/445] bitcoin: testing serialize_tests
[414/445] Running utility command for check-bitcoin-radix_tests
[415/445] Running utility command for check-bitcoin-blockcheck_tests
[416/445] bitcoin: testing cuckoocache_tests
[417/445] Running utility command for check-bitcoin-op_reversebytes_tests
[418/445] Running utility command for check-bitcoin-serialize_tests
[419/445] Running utility command for check-bitcoin-cuckoocache_tests
[420/445] bitcoin: testing script_standard_tests
[421/445] bitcoin: testing validationinterface_tests
[422/445] bitcoin: testing schnorr_tests
[423/445] Running utility command for check-bitcoin-script_standard_tests
[424/445] Running utility command for check-bitcoin-validationinterface_tests
[425/445] Running utility command for check-bitcoin-schnorr_tests
[426/445] bitcoin: testing cashaddr_tests
[427/445] bitcoin: testing util_tests
[428/445] Running utility command for check-bitcoin-cashaddr_tests
[429/445] Running utility command for check-bitcoin-util_tests
[430/445] bitcoin: testing blockstatus_tests
[431/445] Running utility command for check-bitcoin-blockstatus_tests
[432/445] bitcoin: testing crypto_tests
[433/445] bitcoin: testing script_tests
[434/445] bitcoin: testing versionbits_tests
[435/445] Running utility command for check-bitcoin-crypto_tests
[436/445] Running utility command for check-bitcoin-script_tests
[437/445] Running utility command for check-bitcoin-versionbits_tests
[438/445] bitcoin: testing monolith_opcodes_tests
[439/445] Running utility command for check-bitcoin-monolith_opcodes_tests
[440/445] bitcoin: testing transaction_tests
[441/445] Running utility command for check-bitcoin-transaction_tests
[442/445] bitcoin: testing coins_tests
[443/445] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

rebase (unrelated failure)

This revision is now accepted and ready to land.Mon, Jun 7, 16:31