HomePhabricator

refactor: Detach wallet transaction methods (followup for move-only)

Description

refactor: Detach wallet transaction methods (followup for move-only)

Summary:
Followup to commit "MOVEONLY: CWallet transaction code out of
wallet.cpp/.h" that detaches and renames some CWalletTx methods, making
into them into standalone functions or CWallet methods instead.

There are no changes in behavior and no code changes that aren't purely
mechanical. It just gives spend and receive functions more consistent
names and removes the circular dependencies added by the earlier
MOVEONLY commit.

There are also no comment or documentation changes. Removed comments
from transaction.h are just migrated to spend.h, receive.h, and
wallet.h.

Note:

  • the function AttemptSelection from the source material is named SelectCoinsMinConf in BitcoinABC because we miss core#22008

This is a backport of core#22100

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12784

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Feb 12 2021, 23:01
PiRKCommitted on Dec 8 2022, 12:41
PiRKPushed on Dec 8 2022, 12:41
Reviewer
Restricted Project
Differential Revision
D12784: refactor: Detach wallet transaction methods (followup for move-only)
Parents
rABC489c4ac828f8: Rename sigOps to sigChecks in functional tests
Branches
Unknown
Tags
Unknown