HomePhabricator

[backport#14689] Require a public key to be retrieved when signing a P2PKH input

Description

[backport#14689] Require a public key to be retrieved when signing a P2PKH input

Summary:
If we do not have the public key for a P2PKH input, we should not
continue to attempt to sign for it.


Depends on D6028

This is a backport of Core PR14689

Test Plan:

cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6029

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Nov 8 2018, 15:08
majcostaCommitted on May 11 2020, 16:57
majcostaPushed on May 11 2020, 16:58
Reviewer
Restricted Project
Differential Revision
D6029: [backport#14689] Require a public key to be retrieved when signing a P2PKH input
Parents
rABCd8f89cfc896c: [backport#14424] Stop requiring imported pubkey to sign non-PKH schemes
Branches
Unknown
Tags
Unknown