Page MenuHomePhabricator
Differential D6029

[backport#14689] Require a public key to be retrieved when signing a P2PKH input
ClosedPublic
Actions

Authored by majcosta on May 11 2020, 15:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING80241e1f4a65: [backport#14689] Require a public key to be retrieved when signing a P2PKH input
rABC80241e1f4a65: [backport#14689] Require a public key to be retrieved when signing a P2PKH input
Summary

If we do not have the public key for a P2PKH input, we should not
continue to attempt to sign for it.

Depends on D6028

This is a backport of Core PR14689

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 11 2020, 15:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 15:18
majcosta requested review of this revision.May 11 2020, 15:18
teamcity edited the summary of this revision. (Show Details)May 11 2020, 15:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 11 2020, 15:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 11 2020, 15:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10685: Diff 19887.May 11 2020, 15:28
majcosta added a child revision: D6030: [backport#14690] Throw error if CPubKey is invalid during PSBT keypath serialization.May 11 2020, 15:43
deadalnix accepted this revision.May 11 2020, 16:28
This revision is now accepted and ready to land.May 11 2020, 16:28
Closed by commit rABC80241e1f4a65: [backport#14689] Require a public key to be retrieved when signing a P2PKH input (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyMay 11 2020, 16:58
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC80241e1f4a65: [backport#14689] Require a public key to be retrieved when signing a P2PKH input.
majcosta added a commit: rSTAGING80241e1f4a65: [backport#14689] Require a public key to be retrieved when signing a P2PKH input.May 11 2020, 17:00

Revision Contents
Changeset List

PathSize
src/
script/
4 lines
test/
functional/
6 lines

Diff 19896

View Options

src/script/sign.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...