Page MenuHomePhabricator

[backport#14689] Require a public key to be retrieved when signing a P2PKH input
ClosedPublic

Authored by majcosta on May 11 2020, 15:18.

Details

Summary

If we do not have the public key for a P2PKH input, we should not
continue to attempt to sign for it.


Depends on D6028

This is a backport of Core PR14689

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 11 2020, 15:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 15:18
majcosta requested review of this revision.May 11 2020, 15:18
teamcity edited the summary of this revision. (Show Details)May 11 2020, 15:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.May 11 2020, 16:28
This revision is now accepted and ready to land.May 11 2020, 16:28