HomePhabricator

Call CAddrMan::Good() on block-relay-only peer addresses

Description

Call CAddrMan::Good() on block-relay-only peer addresses

Summary:
Being able to invoke Good() is important for address management (new vs tried
table, tried table eviction via test-before-evict). We mitigate potential
information leaks by not calling Connected() on these peer addresses.

This is a backport of core#20187 [3/4]
https://github.com/bitcoin/bitcoin/pull/20187/commits/4fe338ab3ed73b3ffb20eedf95500c56ec2920e1

Depends on D10695

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10696

Details

Provenance
Suhas Daftuar <sdaftuar@gmail.com>Authored on Oct 19 2020, 13:31
PiRKCommitted on Dec 21 2021, 07:19
PiRKPushed on Dec 21 2021, 07:19
Reviewer
Restricted Project
Differential Revision
D10696: Call CAddrMan::Good() on block-relay-only peer addresses
Parents
rABCd924bd2a89e2: Refactor test for existing peer connection into own function
Branches
Unknown
Tags
Unknown