Page MenuHomePhabricator

Call CAddrMan::Good() on block-relay-only peer addresses
ClosedPublic

Authored by PiRK on Dec 20 2021, 13:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC811f79967ee2: Call CAddrMan::Good() on block-relay-only peer addresses
Summary

Being able to invoke Good() is important for address management (new vs tried
table, tried table eviction via test-before-evict). We mitigate potential
information leaks by not calling Connected() on these peer addresses.

This is a backport of core#20187 [3/4]
https://github.com/bitcoin/bitcoin/pull/20187/commits/4fe338ab3ed73b3ffb20eedf95500c56ec2920e1

Depends on D10695

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable