HomePhabricator

[backport#15638] [build] Move rpc rawtransaction util functions to…

Description

[backport#15638] [build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp

Summary:
rpc/rawtransaction.cpp moves to libbitcoin_server since it should not be
accessed by non-node libraries. The utility following utility methods
move to their own unit rpc/rawtransaction_util since they need to be
accessed by non-node libraries:

  • ConstructTransaction
  • TxInErrorToJSON
  • SignTransaction

https://github.com/bitcoin/bitcoin/pull/15638/commits/0509465542d63a5bbe7296f283f44dd491e74f78


Depends on D5979

This is a partial backport of Core PR15638

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5983

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Apr 2 2019, 20:51
majcostaCommitted on May 6 2020, 19:58
majcostaPushed on May 6 2020, 19:58
Reviewer
Restricted Project
Differential Revision
D5983: [backport#15638] [build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp
Parents
rABC6cf20d4d4116: [backport#15638] [build] Move rpc utility methods to rpc/util
Branches
Unknown
Tags
Unknown