Paths

Table of Contentst

Differential D5979

[backport#15638] [build] Move rpc utility methods to rpc/util
ClosedPublic
Actions

Authored by majcosta on May 6 2020, 15:01.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6cf20d4d4116: [backport#15638] [build] Move rpc utility methods to rpc/util
rABC6cf20d4d4116: [backport#15638] [build] Move rpc utility methods to rpc/util

Summary

Moves the following utility methods to rpc/util and moves that unit to
libbitcoin_common so they can be accessed by all libraries.

RPCTypeCheck
RPCTypeCheckArgument
RPCTypeCheckObj
AmountFromValue
ParseHashVParseHashO
ParseHexV
ParseHexO
HelpExampleCli
HelpExampleRpc

https://github.com/bitcoin/bitcoin/pull/15638/commits/1acc61f8746bc6efb905e121a9f607c4f5982b35

Depends on D5967

This is a partial backport of Core PR15638

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 6 2020, 15:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 15:01

majcosta requested review of this revision.May 6 2020, 15:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10612: Diff 19749.May 6 2020, 15:15

deadalnix requested changes to this revision.May 6 2020, 15:30

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/Makefile.am
494 ↗	(On Diff #19749)	Please make sure you get the build change right, this isn't the first time you get this wrong. That file wasn't created in this patch, so very clearly it was somewhere else and was moved here.

This revision now requires changes to proceed.May 6 2020, 15:30

removed util.cpp from libbitcoin_util_a section

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10614: Diff 19751.May 6 2020, 17:21

cmake build.

This revision now requires changes to proceed.May 6 2020, 17:26

fixed cmake build

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.May 6 2020, 18:47

This revision is now accepted and ready to land.May 6 2020, 18:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10619: Diff 19758.May 6 2020, 18:49

Closed by commit rABC6cf20d4d4116: [backport#15638] [build] Move rpc utility methods to rpc/util (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 6 2020, 19:04

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC6cf20d4d4116: [backport#15638] [build] Move rpc utility methods to rpc/util.

majcosta added a commit: rSTAGING6cf20d4d4116: [backport#15638] [build] Move rpc utility methods to rpc/util.

majcosta added a child revision: D5983: [backport#15638] [build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp.May 6 2020, 19:31

Revision Contents
Changeset List

Path

Size

src/

2 lines

2 lines

rpc/

47 lines

124 lines

49 lines

127 lines

test/

script_tests.cpp

2 lines

Diff 19760

src/CMakeLists.txt

Loading...

src/Makefile.am

Loading...

src/rpc/server.h

Loading...

src/rpc/server.cpp

Loading...

src/rpc/util.h

Loading...

src/rpc/util.cpp

Loading...

src/test/script_tests.cpp

Loading...