Page MenuHomePhabricator

[backport#15638] [build] Move policy settings to new src/policy/settings unit
ClosedPublic

Authored by majcosta on May 5 2020, 16:04.

Details

Summary

This moves the following policy settings functions and globals to a new
src/policy/settings unit in lib_server:

  • incrementalRelayFee
  • dustRelayFee
  • nBytesPerSigOp
  • fIsBareMultisigStd

These settings are only required by the node and should not be accessed
by other libraries.

https://github.com/bitcoin/bitcoin/pull/15638/commits/4a75c9d6512a5580e60104103ea11d2cd9586354


Depends on D5963

This is a partial backport of Core PR15638

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta requested review of this revision.May 5 2020, 16:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 5 2020, 18:31
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/CMakeLists.txt
500 ↗(On Diff #19443)

This was removed from server in the PR.

src/policy/settings.h
13 ↗(On Diff #19443)

uint32_t

This revision now requires changes to proceed.May 5 2020, 18:31

removed policy/policy.cpp from server library and replaced unsigned int with correct type

This revision is now accepted and ready to land.May 6 2020, 01:08