Page MenuHomePhabricator
Differential D5962

[backport#13695] lint: Add linter for circular dependencies
ClosedPublic
Actions

Authored by majcosta on May 5 2020, 14:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING40951742d8b0: [backport#13695] lint: Add linter for circular dependencies
rABC40951742d8b0: [backport#13695] lint: Add linter for circular dependencies
Summary

Protects against added circular depencies, makes it explicit in the
code when circular dependencies have been removed.

Modeled after EXPECTED_BOOST_INCLUDES in lint-includes.sh

This is a backport of Core PR13695

Test Plan
run ./test/lint/lint-circular-dependencies.py
see output that points existing unexpected dependencies,
expected dependencies that aren't present and unexpected
dependencies that are.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 5 2020, 14:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 14:09
majcosta requested review of this revision.May 5 2020, 14:09
teamcity edited the summary of this revision. (Show Details)May 5 2020, 14:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 5 2020, 14:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta added a child revision: D5963: [lint-circular-dependencies] changed expected dep list to establish baseline.May 5 2020, 14:17
teamcity added a comment.May 5 2020, 14:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10589: Diff 19434.May 5 2020, 14:19
deadalnix accepted this revision.May 5 2020, 19:05
This revision is now accepted and ready to land.May 5 2020, 19:05
Closed by commit rABC40951742d8b0: [backport#13695] lint: Add linter for circular dependencies (authored by Ben Woosley <ben.woosley@gmail.com>, committed by majcosta). · Explain WhyMay 5 2020, 19:58
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC40951742d8b0: [backport#13695] lint: Add linter for circular dependencies.
majcosta added a commit: rSTAGING40951742d8b0: [backport#13695] lint: Add linter for circular dependencies.May 6 2020, 14:35

Revision Contents
Changeset List

PathSize
test/
lint/
84 lines

Diff 19703

View Options

test/lint/lint-circular-dependencies.sh

Loading...