HomePhabricator

[backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus

Description

[backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus

Summary:
CheckTransaction (N.f.B: CheckCoinbase, CheckTransactionCommon and CheckRegularTransaction
in our case ) is a context-free function that does not require access to the blockchain
or mempool. Move it from src/consensus/tx_verify in lib_server to a new unit
src/consensus/tx_check in lib_consensus so that it can be called by non-server libraries.

fdf8888b6f0c63e8a4cb1459752625e642d6a4dd (John Newbery)


This is a partial backport of Core PR15638

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5961

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Apr 2 2019, 17:41
majcostaCommitted on May 5 2020, 15:56
majcostaPushed on May 5 2020, 15:56
Reviewer
Restricted Project
Differential Revision
D5961: [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus
Parents
rABCb0256317829a: qa: Make extended tests pass on native Windows
Branches
Unknown
Tags
Unknown