Page MenuHomePhabricator

[backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus
ClosedPublic

Authored by majcosta on May 5 2020, 12:40.

Details

Summary

CheckTransaction (N.f.B: CheckCoinbase, CheckTransactionCommon and CheckRegularTransaction
in our case ) is a context-free function that does not require access to the blockchain
or mempool. Move it from src/consensus/tx_verify in lib_server to a new unit
src/consensus/tx_check in lib_consensus so that it can be called by non-server libraries.

fdf8888b6f0c63e8a4cb1459752625e642d6a4dd (John Newbery)


This is a partial backport of Core PR15638

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta requested review of this revision.May 5 2020, 12:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 5 2020, 14:02
deadalnix added a subscriber: deadalnix.

Please indicate the specific commit.

This revision now requires changes to proceed.May 5 2020, 14:02
majcosta requested review of this revision.May 5 2020, 14:11
majcosta edited the summary of this revision. (Show Details)

specific commit linked in summary

deadalnix added inline comments.
src/consensus/tx_check.h
17 ↗(On Diff #19433)

Add new line.

This revision is now accepted and ready to land.May 5 2020, 15:24