HomePhabricator

[backport#13695] lint: Add linter for circular dependencies

Description

[backport#13695] lint: Add linter for circular dependencies

Summary:
Protects against added circular depencies, makes it explicit in the
code when circular dependencies have been removed.

Modeled after EXPECTED_BOOST_INCLUDES in lint-includes.sh


This is a backport of Core PR13695

Test Plan:

run ./test/lint/lint-circular-dependencies.py
see output that points existing unexpected dependencies,
expected dependencies that aren't present and unexpected
dependencies that are.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5962

Details

Provenance
Ben Woosley <ben.woosley@gmail.com>Authored on Jul 17 2018, 20:50
majcostaCommitted on May 5 2020, 19:58
majcostaPushed on May 5 2020, 19:58
Reviewer
Restricted Project
Differential Revision
D5962: [backport#13695] lint: Add linter for circular dependencies
Parents
rABCa482f6fb1f86: [backport#15638] [build] Move CheckTransaction from lib_server to lib_consensus
Branches
Unknown
Tags
Unknown