Page MenuHomePhabricator
Differential D5967

[backport#15638] [build] Move policy settings to new src/policy/settings unit
ClosedPublic
Actions

Authored by majcosta on May 5 2020, 16:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGeb5113eaa64c: [backport#15638] [build] Move policy settings to new src/policy/settings unit
rABCeb5113eaa64c: [backport#15638] [build] Move policy settings to new src/policy/settings unit
Summary

This moves the following policy settings functions and globals to a new
src/policy/settings unit in lib_server:

  • incrementalRelayFee
  • dustRelayFee
  • nBytesPerSigOp
  • fIsBareMultisigStd

These settings are only required by the node and should not be accessed
by other libraries.

https://github.com/bitcoin/bitcoin/pull/15638/commits/4a75c9d6512a5580e60104103ea11d2cd9586354

Depends on D5963

This is a partial backport of Core PR15638

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15638pluslint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10594
Build 18998: Default Diff Build & Tests
Build 18997: arc lint + arc unit

Event Timeline

majcosta created this revision.May 5 2020, 16:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 16:04
majcosta requested review of this revision.May 5 2020, 16:04
teamcity edited the summary of this revision. (Show Details)May 5 2020, 16:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 5 2020, 16:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 5 2020, 16:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10594: Diff 19443.May 5 2020, 16:17
deadalnix requested changes to this revision.May 5 2020, 18:31
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/CMakeLists.txt
500

This was removed from server in the PR.

src/policy/settings.h
13

uint32_t

This revision now requires changes to proceed.May 5 2020, 18:31
majcosta updated this revision to Diff 19702.May 5 2020, 19:41

removed policy/policy.cpp from server library and replaced unsigned int with correct type

teamcity added a comment.May 5 2020, 19:42

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 5 2020, 19:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10597: Diff 19702.May 5 2020, 19:52
deadalnix accepted this revision.May 6 2020, 01:08
This revision is now accepted and ready to land.May 6 2020, 01:08
Closed by commit rABCeb5113eaa64c: [backport#15638] [build] Move policy settings to new src/policy/settings unit (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 6 2020, 10:04
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCeb5113eaa64c: [backport#15638] [build] Move policy settings to new src/policy/settings unit.
majcosta added a commit: rSTAGINGeb5113eaa64c: [backport#15638] [build] Move policy settings to new src/policy/settings unit.May 6 2020, 14:35
majcosta added a child revision: D5979: [backport#15638] [build] Move rpc utility methods to rpc/util.May 6 2020, 15:01
majcosta mentioned this in D6252: [refactor] remove indirect constant reference in policy.h.May 25 2020, 21:41
majcosta mentioned this in D6253: fix wrong include prior to backporting 15639.May 26 2020, 02:26
majcosta mentioned this in rABCed7b9d668939: fix wrong include prior to backporting 15639.May 26 2020, 11:59

Revision Contents
Changeset List

PathSize
src/
2 lines
4 lines
1 line
interfaces/
1 line
1 line
policy/
6 lines
4 lines
16 lines
13 lines
rpc/
1 line
test/
1 line
1 line
1 line
3 lines
2 lines
test/
lint/
1 line

Diff 19443

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/init.cpp

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/policy/settings.h

Loading...
View Options

src/policy/settings.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/script_p2sh_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/lint/lint-circular-dependencies.sh

Loading...