HomePhabricator

Merge #10911: [qt] Fix typo and access key in optionsdialog.ui

Description

Merge #10911: [qt] Fix typo and access key in optionsdialog.ui

Summary:
d2be7b25b Typo in optionsdialog.ui Tooltip displayed ampersand incorrectly, & should be in text. (James Evans)

Pull request description:

Tooltip displayed ampersand incorrectly, & should be in text property rather than tooltip so that access key is correctly displayed for accessibility.

Tree-SHA512: 331848207317d37d4d9db40119d0b7ae9a276d06cd1b057cd0e87d508e1aa769b785246ca30ca9156db632798ec9f68ba8bf78cf42904267b4187bd27cfced35

Backport of Core PR10911
https://github.com/bitcoin/bitcoin/pull/10911/files

Test Plan:

# on master
bitcoin-qt
# See that the text strings in this diff do not have their accessibility key underlined.
# See that Settings -> Options -> Window, hovering over "Hide tray icon" has an errant ampersand.

# with this patch applied
make check
bitcoin-qt
# See that the text strings now have their accessibility keys underlined.
# See that the errant ampersand is now gone.

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3221

Details

Provenance
Jonas Schnelli <dev@jonasschnelli.ch>Authored on Sep 7 2017, 15:59
jasonbcoxCommitted on Jun 6 2019, 21:07
jasonbcoxPushed on Jun 6 2019, 21:07
Reviewer
Restricted Project
Differential Revision
D3221: Merge #10911: [qt] Fix typo and access key in optionsdialog.ui
Parents
rABC78bd3d936ece: remove four duplicate tests from script_tests.json
Branches
Unknown
Tags
Unknown