Page MenuHomePhabricator

Merge #10911: [qt] Fix typo and access key in optionsdialog.ui
ClosedPublic

Authored by jasonbcox on Wed, Jun 5, 20:31.

Details

Summary

d2be7b25b Typo in optionsdialog.ui Tooltip displayed ampersand incorrectly, & should be in text. (James Evans)

Pull request description:

Tooltip displayed ampersand incorrectly, & should be in text property rather than tooltip so that access key is correctly displayed for accessibility.

Tree-SHA512: 331848207317d37d4d9db40119d0b7ae9a276d06cd1b057cd0e87d508e1aa769b785246ca30ca9156db632798ec9f68ba8bf78cf42904267b4187bd27cfced35

Backport of Core PR10911
https://github.com/bitcoin/bitcoin/pull/10911/files

Test Plan
# on master
bitcoin-qt
# See that the text strings in this diff do not have their accessibility key underlined.
# See that Settings -> Options -> Window, hovering over "Hide tray icon" has an errant ampersand.

# with this patch applied
make check
bitcoin-qt
# See that the text strings now have their accessibility keys underlined.
# See that the errant ampersand is now gone.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Wed, Jun 5, 20:31
Fabien accepted this revision.Thu, Jun 6, 08:06
This revision is now accepted and ready to land.Thu, Jun 6, 08:06
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.