HomePhabricator

[Cashtab][Alias] Increase pending warning emphasis on confirmation modal

Description

[Cashtab][Alias] Increase pending warning emphasis on confirmation modal

Summary:

  • The title is now conditionally rendered: it's Confirm alias registration when the alias is available with no pending txs, otherwise it's a Warning title with icon.
  • Modal body text also conditionally rendered based on existance of pending txs for this alias, with color scheme updated to use green for alias availability and the default alert color for the pending warning

Test Plan:

  • Register a new alias and verify the confirmation dialog only has the confirmation message
  • Register the same new alias and confirm the pending substrings and UI make match the following:

When alias is available with no pending registrations onchain

image.png (266×573 px, 27 KB)

When alias is available with existing pending registrations from other users but not from this wallet

image.png (294×547 px, 28 KB)

When alias is available with existing pending registrations which includes registrations from this wallet

image.png (308×544 px, 32 KB)

Alias available, there are pending txs including from this wallet, and registration is on behalf of another address

image.png (375×554 px, 43 KB)

Reviewers: bytesofman, #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D14725

Details

Provenance
emackAuthored on Nov 2 2023, 01:59
emackPushed on Nov 3 2023, 14:13
Reviewer
Restricted Project
Differential Revision
D14725: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal
Parents
rABC55867cb13628: [avalanche] Consolidate the proofs recent finalization state memorization
Branches
Unknown
Tags
Unknown