- The title is now conditionally rendered: it's Confirm alias registration when the alias is available with no pending txs, otherwise it's a Warning title with icon.
- Modal body text also conditionally rendered based on existance of pending txs for this alias, with color scheme updated to use green for alias availability and the default alert color for the pending warning
Details
Details
- Reviewers
bytesofman Fabien - Group Reviewers
Restricted Project - Commits
- rABC86052e98a0fb: [Cashtab][Alias] Increase pending warning emphasis on confirmation modal
- Register a new alias and verify the confirmation dialog only has the confirmation message
- Register the same new alias and confirm the pending substrings and UI make match the following:
When alias is available with no pending registrations onchain
When alias is available with existing pending registrations from other users but not from this wallet
When alias is available with existing pending registrations which includes registrations from this wallet
Alias available, there are pending txs including from this wallet, and registration is on behalf of another address
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
In the case there are pending alias you should not have the green "everything is fine" register confirmation text, but rather something purple like "Continue the registration anyway ?"
Comment Actions
Updated UI as follows
Pending alias including 1 for this address
Pending alias including 1 that’s not from this address
Pending alias from this wallet + registering on behalf of another address
No change to no pending UI