Diffusion Bitcoin ABC 942d91965b1a

test, build: Enable -Werror=sign-compare
942d91965b1a
Actions

Description

test, build: Enable -Werror=sign-compare

Summary:
test: Fix outstanding -Wsign-compare errors
refactor: Rework asmap Interpret to avoid ptrdiff_t

This is a backport of Core PR18216

It also includes a change in asmap.cpp that was missed in D9055 (PR18512)

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9197

Details

Provenance

Ben Woosley <ben.woosley@gmail.com>	Authored on Feb 10 2021, 17:04
PiRK	Committed on Feb 10 2021, 17:04
abc-bot	Pushed on Feb 10 2021, 17:11

Reviewer

Restricted Project

Differential Revision

D9197: test, build: Enable -Werror=sign-compare

Parents

rABC21862c3cda83: p2p: Unify Send and Receive protocol versions

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABC942d91965b1a: test, build: Enable -Werror=sign-compare (authored by Ben Woosley <ben.woosley@gmail.com>).Feb 10 2021, 17:04

PiRK added an edge: D9197: test, build: Enable -Werror=sign-compare.Feb 10 2021, 17:11

teamcity mentioned this in T1496: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken..Feb 10 2021, 17:22

Changes (15)

Path

Size

src/

CMakeLists.txt

test/

blockfilter_index_tests.cpp

blockfilter_tests.cpp

util_threadnames_tests.cpp

validation_flush_tests.cpp

util/

asmap.cpp

wallet/

test/

wallet_tests.cpp

rABC942d91965b1a

View Options

src/CMakeLists.txt

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/blockfilter_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/compress_tests.cpp

View Options

src/test/descriptor_tests.cpp

View Options

src/test/flatfile_tests.cpp

View Options

src/test/netbase_tests.cpp

View Options

src/test/random_tests.cpp

View Options

src/test/streams_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/test/util_threadnames_tests.cpp

View Options

src/test/validation_flush_tests.cpp

View Options

src/util/asmap.cpp

View Options

src/wallet/test/wallet_tests.cpp

test, build: Enable -Werror=sign-compare942d91965b1aActions

Description

Details

Event Timeline

Changes (15)

rABC942d91965b1a

src/CMakeLists.txt

src/test/blockfilter_index_tests.cpp

src/test/blockfilter_tests.cpp

src/test/bloom_tests.cpp

src/test/compress_tests.cpp

src/test/descriptor_tests.cpp

src/test/flatfile_tests.cpp

src/test/netbase_tests.cpp

src/test/random_tests.cpp

src/test/streams_tests.cpp

src/test/util_tests.cpp

src/test/util_threadnames_tests.cpp

src/test/validation_flush_tests.cpp

src/util/asmap.cpp

src/wallet/test/wallet_tests.cpp

test, build: Enable -Werror=sign-compare
942d91965b1a
Actions