Page MenuHomePhabricator

test, build: Enable -Werror=sign-compare
ClosedPublic

Authored by PiRK on Wed, Feb 10, 07:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC942d91965b1a: test, build: Enable -Werror=sign-compare
Summary

test: Fix outstanding -Wsign-compare errors
refactor: Rework asmap Interpret to avoid ptrdiff_t

This is a backport of Core PR18216

It also includes a change in asmap.cpp that was missed in D9055 (PR18512)

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Wed, Feb 10, 07:30
Fabien added inline comments.
src/test/blockfilter_index_tests.cpp
281 ↗(On Diff #27627)

We should use BOOST_CHECK instead. This does the same thing, but will throw a useful message rather than a brutal abort in case this is false.

This revision is now accepted and ready to land.Wed, Feb 10, 10:21

use boost_check instead of assert