Paths

Table of Contentst

Differential D9197

test, build: Enable -Werror=sign-compare
ClosedPublic
Actions

Authored by PiRK on Feb 10 2021, 07:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC942d91965b1a: test, build: Enable -Werror=sign-compare

Summary

test: Fix outstanding -Wsign-compare errors
refactor: Rework asmap Interpret to avoid ptrdiff_t

This is a backport of Core PR18216

It also includes a change in asmap.cpp that was missed in D9055 (PR18512)

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18216

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15162
Build 30271: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-without-wallet · build-clang
Build 30270: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 10 2021, 07:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2021, 07:30

PiRK requested review of this revision.Feb 10 2021, 07:30

teamcity edited the summary of this revision. (Show Details)Feb 10 2021, 07:31

teamcity edited the summary of this revision. (Show Details)Feb 10 2021, 07:36

Harbormaster completed remote builds in B15162: Diff 27627.Feb 10 2021, 07:45

Fabien edited the summary of this revision. (Show Details)Feb 10 2021, 10:07

@bot build-fuzzer

teamcity awarded a token.Feb 10 2021, 10:11

Fabien accepted this revision.Feb 10 2021, 10:21

Fabien added inline comments.

src/test/blockfilter_index_tests.cpp
281	We should use `BOOST_CHECK` instead. This does the same thing, but will throw a useful message rather than a brutal abort in case this is false.

This revision is now accepted and ready to land.Feb 10 2021, 10:21

use boost_check instead of assert

Harbormaster completed remote builds in B15168: Diff 27633.Feb 10 2021, 12:10

Closed by commit rABC942d91965b1a: test, build: Enable -Werror=sign-compare (authored by Ben Woosley <ben.woosley@gmail.com>, committed by PiRK). · Explain WhyFeb 10 2021, 17:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC942d91965b1a: test, build: Enable -Werror=sign-compare.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

test/

blockfilter_index_tests.cpp

9 lines

blockfilter_tests.cpp

10 lines

4 lines

16 lines

2 lines

16 lines

2 lines

2 lines

44 lines

28 lines

util_threadnames_tests.cpp

2 lines

validation_flush_tests.cpp

4 lines

util/

asmap.cpp

18 lines

wallet/

test/

wallet_tests.cpp

8 lines

Diff 27627

View Options

src/CMakeLists.txt

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/blockfilter_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/compress_tests.cpp

View Options

src/test/descriptor_tests.cpp

View Options

src/test/flatfile_tests.cpp

View Options

src/test/netbase_tests.cpp

View Options

src/test/random_tests.cpp

View Options

src/test/streams_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/test/util_threadnames_tests.cpp

View Options

src/test/validation_flush_tests.cpp

View Options

src/util/asmap.cpp

View Options

src/wallet/test/wallet_tests.cpp

test, build: Enable -Werror=sign-compareClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27627

src/CMakeLists.txt

src/test/blockfilter_index_tests.cpp

src/test/blockfilter_tests.cpp

src/test/bloom_tests.cpp

src/test/compress_tests.cpp

src/test/descriptor_tests.cpp

src/test/flatfile_tests.cpp

src/test/netbase_tests.cpp

src/test/random_tests.cpp

src/test/streams_tests.cpp

src/test/util_tests.cpp

src/test/util_threadnames_tests.cpp

src/test/validation_flush_tests.cpp

src/util/asmap.cpp

src/wallet/test/wallet_tests.cpp

test, build: Enable -Werror=sign-compare
ClosedPublic
Actions

Revision Contents
Changeset List