HomePhabricator

gui: Remove WalletView and BitcoinGUI circular dependency

Description

gui: Remove WalletView and BitcoinGUI circular dependency

Summary:

Essentially moves the code in WalletView::setBitcoinGUI to the only caller.

Remove the circular dependency "qt/bitcoingui -> qt/walletview -> qt/bitcoingui"

This is a backport of Core PR17937 [2/2]
https://github.com/bitcoin/bitcoin/pull/17937/commits/cb8a86d9f952401eaad68b2e3818ce50f7befd91

Depends on D8698

Test Plan:
ninja && src/qt/bitcoin-qt
Test some of the connections

Run test/lint/lint-circular-dependencies.sh

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8699

Details

Provenance
João Barbosa <joao.paulo.barbosa@gmail.com>Authored on Jan 15 2020, 22:55
PiRKCommitted on Dec 19 2020, 11:43
PiRKPushed on Dec 19 2020, 11:43
Reviewer
Restricted Project
Differential Revision
D8699: gui: Remove WalletView and BitcoinGUI circular dependency
Parents
rABC9623f4e18632: test: remove getaddressinfo label tests
Branches
Unknown
Tags
Unknown