HomePhabricator

refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG

Description

refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG

Summary:
This makes OP_CHECKSIG resemble the logic in OP_CHECKDATASIG a bit
closer. Also, we can move the nullfail check into the if statements
so why not (I think this makes it clearer).

Note that due to intermingling of pubkey encoding checks and signature
checks, it is unfortunately not so easy to do a similar thing for
OP_CHECKMULTISIG.

Test Plan: make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4766

Details

Provenance
Mark Lundeberg <markblundeberg@users.noreply.github.com>Authored on Dec 19 2019, 08:10
markblundebergPushed on Dec 23 2019, 02:10
Reviewer
Restricted Project
Differential Revision
D4766: refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG
Parents
rABC0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool
Branches
Unknown
Tags
Unknown

Event Timeline