Page MenuHomePhabricator

refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG
ClosedPublic

Authored by markblundeberg on Dec 19 2019, 11:49.

Details

Summary

This makes OP_CHECKSIG resemble the logic in OP_CHECKDATASIG a bit
closer. Also, we can move the nullfail check into the if statements
so why not (I think this makes it clearer).

Note that due to intermingling of pubkey encoding checks and signature
checks, it is unfortunately not so easy to do a similar thing for
OP_CHECKMULTISIG.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Dec 19 2019, 21:04