Page MenuHomePhabricator
Differential D4766

refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG
ClosedPublic
Actions

Authored by markblundeberg on Dec 19 2019, 11:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING95b3682e2f76: refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG
rABC95b3682e2f76: refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG
Summary

This makes OP_CHECKSIG resemble the logic in OP_CHECKDATASIG a bit
closer. Also, we can move the nullfail check into the if statements
so why not (I think this makes it clearer).

Note that due to intermingling of pubkey encoding checks and signature
checks, it is unfortunately not so easy to do a similar thing for
OP_CHECKMULTISIG.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ref_signull
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8638
Build 15262: Default Diff Build & Tests
Build 15261: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Dec 19 2019, 11:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2019, 11:49
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 19 2019, 11:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 19 2019, 12:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8638: Diff 14990.Dec 19 2019, 12:03
deadalnix accepted this revision.Dec 19 2019, 21:04
This revision is now accepted and ready to land.Dec 19 2019, 21:04
Closed by commit rABC95b3682e2f76: refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyDec 23 2019, 02:10
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC95b3682e2f76: refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG.
markblundeberg mentioned this in D4678: add nSigChecks counting to EvalScript.Dec 23 2019, 02:21
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING95b3682e2f76: refactor null-signature checks in OP_CHECKSIG, OP_CHECKDATASIG.Apr 7 2020, 22:13

Revision Contents
Changeset List

PathSize
src/
script/
31 lines

Diff 14990

View Options

src/script/interpreter.cpp

Loading...