refactor: Use AbortError in FatalError
Summary:
FatalError has been copied from AbortNode, so the two should use the same style to avoid confusion. Follow-up to #18927
Backport of core PR19295, PR19309 and PR19331.
PR19295 is the original intent
PR19309 is a hacky bug fix
PR19331 reverts PR19309 and fixes PR19295.
In the end the relevant commits are:
https://github.com/bitcoin/bitcoin/pull/19295/commits/fa02b473132932c200be1750d1a5b1de14ea2383
https://github.com/bitcoin/bitcoin/pull/19331/commits/fac96e6450d595fe67168cb7afa7692da6cc9973
https://github.com/bitcoin/bitcoin/pull/19331/commits/fa72ca6a9d90d66012765b0043fd819698b94ba8
https://github.com/bitcoin/bitcoin/pull/19331/commits/cccc2784a3bb10fa8e43be7e68207cafb12bd915
Depends on D8649.
Test Plan:
With debug:
ninja all check-all
Reviewers: #bitcoin_abc, jasonbcox
Reviewed By: #bitcoin_abc, jasonbcox
Differential Revision: https://reviews.bitcoinabc.org/D8650