refactor: Use AbortError in FatalError
978bd5b48891
Actions

Description

refactor: Use AbortError in FatalError

Summary:

FatalError has been copied from AbortNode, so the two should use the
same style to avoid confusion.

Follow-up to #18927

Backport of core PR19295, PR19309 and PR19331.
PR19295 is the original intent
PR19309 is a hacky bug fix
PR19331 reverts PR19309 and fixes PR19295.

In the end the relevant commits are:
https://github.com/bitcoin/bitcoin/pull/19295/commits/fa02b473132932c200be1750d1a5b1de14ea2383
https://github.com/bitcoin/bitcoin/pull/19331/commits/fac96e6450d595fe67168cb7afa7692da6cc9973
https://github.com/bitcoin/bitcoin/pull/19331/commits/fa72ca6a9d90d66012765b0043fd819698b94ba8
https://github.com/bitcoin/bitcoin/pull/19331/commits/cccc2784a3bb10fa8e43be7e68207cafb12bd915

Depends on D8649.

Test Plan:
With debug:

ninja all check-all

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8650

Details

Provenance

MarcoFalke <falke.marco@gmail.com>	Authored on Jun 16 2020, 15:02
Fabien	Committed on Dec 11 2020, 07:35
Fabien	Pushed on Dec 11 2020, 07:37

Reviewer

Restricted Project

Differential Revision

D8650: refactor: Use AbortError in FatalError

Parents

rABC1ec7ba83469f: Pass bilingual_str argument to AbortNode()

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC978bd5b48891: refactor: Use AbortError in FatalError (authored by MarcoFalke <falke.marco@gmail.com>).Dec 11 2020, 07:35

Fabien added an edge: D8650: refactor: Use AbortError in FatalError.

Changes (32)

Path

Size

src/

index/

interfaces/

	node/

qt/

util/

wallet/

rABC978bd5b48891

View Options

src/CMakeLists.txt

View Options

src/banman.cpp

View Options

src/bitcoind.cpp

View Options

src/httprpc.cpp

View Options

src/httpserver.cpp

View Options

src/index/base.cpp

View Options

src/index/txindex.cpp

View Options

src/init.cpp

View Options

src/interfaces/chain.cpp

View Options

src/interfaces/node.cpp

View Options

src/interfaces/wallet.cpp

View Options

src/interfaces/wallet.h

View Options

src/net.cpp

View Options

src/node/ui_interface.cpp

View Options

src/node/ui_interface.h

View Options

src/noui.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/splashscreen.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/qt/walletview.cpp

View Options

src/timedata.cpp

View Options

src/txdb.cpp

View Options

src/ui_interface.cpp

View Options

src/ui_interface.h

View Options

src/util/ui_change_type.h

View Options

src/validation.cpp

View Options

src/wallet/init.cpp

View Options

refactor: Use AbortError in FatalError978bd5b48891Actions

Description

Details

Event Timeline

Changes (32)

rABC978bd5b48891

src/CMakeLists.txt

src/banman.cpp

src/bitcoind.cpp

src/httprpc.cpp

src/httpserver.cpp

src/index/base.cpp

src/index/txindex.cpp

src/init.cpp

src/interfaces/chain.cpp

src/interfaces/node.cpp

src/interfaces/wallet.cpp

src/interfaces/wallet.h

src/net.cpp

src/node/ui_interface.cpp

src/node/ui_interface.h

src/noui.cpp

src/qt/bitcoin.cpp

src/qt/bitcoingui.cpp

src/qt/paymentserver.cpp

src/qt/sendcoinsdialog.cpp

src/qt/splashscreen.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.cpp

src/qt/walletview.cpp

src/timedata.cpp

src/txdb.cpp

src/ui_interface.cpp

src/ui_interface.h

src/util/ui_change_type.h

src/validation.cpp

src/wallet/init.cpp

src/wallet/wallet.h

refactor: Use AbortError in FatalError
978bd5b48891
Actions