HomePhabricator

Merge #11385: Remove some unused functions and methods

Authored by Wladimir J. van der Laan <laanwj@gmail.com> on Sep 22 2017, 11:33.

Description

Merge #11385: Remove some unused functions and methods

Summary:
46c9043 Remove some unused functions and methods (Pieter Wuille)

Pull request description:

In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Tree-SHA512: 89715bafe3e0bea2c46fc92bc6a1010360a3fee2719f97b81ca379581003409b0876b50f992208a3c13c7f5b77f1866db09954e7d102f6a452fe5d7aed2044a1

Backport of Core PR11385
https://github.com/bitcoin/bitcoin/pull/11385

Test Plan:

make check
test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3044

Details

Committed
Nico Guiton <nico@bitframe.org>Tue, May 14, 23:09
Pushed
nakihitoTue, May 14, 23:10
Reviewer
Restricted Owners Package
Differential Revision
D3044: Merge #11385: Remove some unused functions and methods
Parents
rABCf4cea37d423c: Remove useless include of boost thread
Branches
Unknown
Tags
Unknown

Event Timeline

Nico Guiton <nico@bitframe.org> committed rABC97b7b1b2388f: Merge #11385: Remove some unused functions and methods (authored by Wladimir J. van der Laan <laanwj@gmail.com>).Tue, May 14, 23:09