Page MenuHomePhabricator

Merge #11385: Remove some unused functions and methods
ClosedPublic

Authored by nakihito on Tue, May 14, 18:24.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC97b7b1b2388f: Merge #11385: Remove some unused functions and methods
Summary

46c9043 Remove some unused functions and methods (Pieter Wuille)

Pull request description:

In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Tree-SHA512: 89715bafe3e0bea2c46fc92bc6a1010360a3fee2719f97b81ca379581003409b0876b50f992208a3c13c7f5b77f1866db09954e7d102f6a452fe5d7aed2044a1

Backport of Core PR11385
https://github.com/bitcoin/bitcoin/pull/11385

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, May 14, 18:24
Owners added a reviewer: Restricted Owners Package.Tue, May 14, 18:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 14, 18:24
deadalnix accepted this revision.Tue, May 14, 22:42
This revision is now accepted and ready to land.Tue, May 14, 22:42
This revision was landed with ongoing or failed builds.Tue, May 14, 23:10
This revision was automatically updated to reflect the committed changes.