HomePhabricator

Merge #13983: rpc: Return more specific reject reason for submitblock

Authored by MarcoFalke <falke.marco@gmail.com> on Sep 13 2018, 13:25.

Description

Merge #13983: rpc: Return more specific reject reason for submitblock

Summary:
fa6ab8ada1 rpc: Return more specific reject reason for submitblock (MarcoFalke)

Pull request description:

The second commit in #13439 made the `TODO` in the first commit impossible to solve.

The meaning of `fNewBlock` changed from "This is the first time we process this block" to "We are about to write the new *valid* block".

So whenever `fNewBlock` is true, the block was valid. And whenever the `fNewBlock` is false, the block is either valid or invalid. If it was valid and not new, we know it is a `"duplicate"`. In all other cases, the `BIP22ValidationResult()` will return the reason why it is invalid.

Tree-SHA512: 4b6edf7a912339c3acb0fccfabbdd6d812a0321fb1639c244c2714e58dc119aa2b8c6bf8f7d61ea609a1b861bbc23f920370fcf989c48452721e259a8ce93d24

Backport Core PR13983
https://github.com/bitcoin/bitcoin/pull/13983/files
Completes T686
Depends on D4046

Test Plan:

make check
test_runner.py

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D4047

Details

Committed
jasonbcoxSep 12 2019, 20:40
Pushed
jasonbcoxSep 12 2019, 20:40
Reviewer
Restricted Project
Differential Revision
D4047: Merge #13983: rpc: Return more specific reject reason for submitblock
Parents
rABC0d917a7b964a: Merge #13399: rpc: Add submitheader
Branches
Unknown
Tags
Unknown