Page MenuHomePhabricator

Merge #13399: rpc: Add submitheader
ClosedPublic

Authored by jasonbcox on Wed, Sep 11, 21:07.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABC0d917a7b964a: Merge #13399: rpc: Add submitheader
Summary

fa091b001605c4481fb4eca415929a98d3478549 qa: Add tests for submitheader (MarcoFalke)
36b1b63f20cc718084971d2cadd04497a9b72634 rpc: Expose ProcessNewBlockHeaders (MarcoFalke)

Pull request description:

This exposes `ProcessNewBlockHeaders` as an rpc called `submitheader`. This can be used to check for invalid block headers and submission of valid block headers via the rpc.

Tree-SHA512: a61e850470f15465f88e450609116df0a98d5d9afadf36b2033d820933d8b6a4012f9f2b3246319c08a0e511bef517f5d808cd0f44ffca91d10895a938004f0b

Backport of Core PR13399
https://github.com/bitcoin/bitcoin/pull/13399/files
Completes T685
Depends on D3856

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Wed, Sep 11, 21:07
Fabien requested changes to this revision.Thu, Sep 12, 06:27
Fabien added a subscriber: Fabien.

Code looks good, but this deserves a release note.

This revision now requires changes to proceed.Thu, Sep 12, 06:27
jasonbcox updated this revision to Diff 11244.Thu, Sep 12, 15:42

Added a release note.

Fabien accepted this revision.Thu, Sep 12, 19:18
This revision is now accepted and ready to land.Thu, Sep 12, 19:18
This revision was automatically updated to reflect the committed changes.