HomePhabricator

refactor: use Span for SipHash::Write

Description

refactor: use Span for SipHash::Write

Summary:

This simple refactoring PR changes the interface for the SipHash arbitrary-data Write method to take a Span<unsigned char> instead of having to pass data and length. (Span<std::byte> seems to be more modern, but vectors of unsigned char are still used prety much everywhere where SipHash is called, and I didn't find it very appealing having to clutter the code with Make(Writable)ByteSpan helpers).

Backport of core#28085.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D18885

Details

Provenance
Sebastian Falbesoner <sebastian.falbesoner@gmail.com>Authored on Jul 17 2023, 01:33
FabienCommitted on Thu, Nov 6, 08:07
FabienPushed on Thu, Nov 6, 08:07
Reviewer
Restricted Project
Differential Revision
D18885: refactor: use Span for SipHash::Write
Parents
rABCefcca6b16a3b: [CI] Bump ASAN timeout
Branches
Unknown
Tags
Unknown

Event Timeline