HomePhabricator

[backport#14935] tests: Test for expected return values when calling functions…

Description

[backport#14935] tests: Test for expected return values when calling functions returning a success code

Summary:
c84c2b8c92 tests: Test for expected return values when calling functions returning a success code (practicalswift)

Pull request description:

Test for expected return values when calling functions returning a success code (instead of discarding the return values).

**Note to reviewers:** The following commands can be used to verify that the only text fragments added in this PR are `BOOST_CHECK(`, `!` and `)` :

```
$ git diff HEAD~1 | grep -E '^[\-][^\-]' | cut -b2- > before.txt
$ git diff HEAD~1 | grep -E '^[\+][^\+]' | cut -b2- > after.txt
$ cat after.txt | sed 's/BOOST_CHECK(//g' | sed 's/));/);/g' | tr -d '!' > after-sed.txt
$ diff -u before.txt after-sed.txt
$
```

Backport of Core PR14935 and PR14969

Test Plan:

ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6663

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Dec 14 2018, 19:21
majcostaCommitted on Jun 22 2020, 09:07
majcostaPushed on Jun 22 2020, 09:07
Reviewer
Restricted Project
Differential Revision
D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code
Parents
rABC06b3ec662d6f: [backport#16079] wallet_balance.py: Prevent edge cases
Branches
Unknown
Tags
Unknown