HomePhabricator

Fix scheduler test race due to BOOST_CHECK in multithreaded context

Description

Fix scheduler test race due to BOOST_CHECK in multithreaded context

Summary:
BOOST_CHECK is not thread safe and will make TSAN to raise a false
race condition in scheduler_tests.

Test Plan:
With TSAN enabled:

./src/test/test_bitcoin -t scheduler_tests

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3609

Details

Provenance
FabienAuthored on Jul 9 2019, 13:47
FabienPushed on Jul 9 2019, 19:00
Reviewer
Restricted Project
Differential Revision
D3609: Fix scheduler test race due to BOOST_CHECK in multithreaded context
Parents
rABC6662b89b2fd6: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests.
Branches
Unknown
Tags
Unknown