Page MenuHomePhabricator

Fix scheduler test race due to BOOST_CHECK in multithreaded context
ClosedPublic

Authored by Fabien on Tue, Jul 9, 13:50.

Details

Summary

BOOST_CHECK is not thread safe and will make TSAN to raise a false
race condition in scheduler_tests.

Test Plan

With TSAN enabled:

./src/test/test_bitcoin -t scheduler_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jul 9, 13:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 9, 13:50
deadalnix accepted this revision.Tue, Jul 9, 17:26
This revision is now accepted and ready to land.Tue, Jul 9, 17:26