Fix scheduler test race due to BOOST_CHECK in multithreaded context
ClosedPublic
Actions

Authored by Fabien on Jul 9 2019, 13:50.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGa07716c93dc9: Fix scheduler test race due to BOOST_CHECK in multithreaded context
rABCa07716c93dc9: Fix scheduler test race due to BOOST_CHECK in multithreaded context

Summary

BOOST_CHECK is not thread safe and will make TSAN to raise a false
race condition in scheduler_tests.

Test Plan

With TSAN enabled:

./src/test/test_bitcoin -t scheduler_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_scheduler_tests_tsan

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6757
Build 11561: Bitcoin ABC Buildbot (legacy)
Build 11560: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 9 2019, 13:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 13:50

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6757: Diff 10128.Jul 9 2019, 14:01

deadalnix accepted this revision.Jul 9 2019, 17:26

This revision is now accepted and ready to land.Jul 9 2019, 17:26

Closed by commit rABCa07716c93dc9: Fix scheduler test race due to BOOST_CHECK in multithreaded context (authored by Fabien). · Explain WhyJul 9 2019, 19:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa07716c93dc9: Fix scheduler test race due to BOOST_CHECK in multithreaded context.

Fabien added a commit: rSTAGINGa07716c93dc9: Fix scheduler test race due to BOOST_CHECK in multithreaded context.Sep 19 2019, 01:07

Revision Contents
Changeset List

Path

Size

src/

test/

scheduler_tests.cpp

2 lines

Diff 10128

View Options

src/test/scheduler_tests.cpp

Fix scheduler test race due to BOOST_CHECK in multithreaded contextClosedPublicActions