HomePhabricator

[qa] don't pad transactions during make_conform_to_ctor

Description

[qa] don't pad transactions during make_conform_to_ctor

Summary:
This is a bad idea, as if it takes effect then it will change txids and
thus can break chains of transactions. Also, it simply does not belong in
this function.

(Introduced in D2086)

Also, fixes test that relied on this behaviour.

Test Plan: test_runner.py --extended

Reviewers: jasonbcox, #bitcoin_abc, deadalnix, Fabien

Reviewed By: jasonbcox, #bitcoin_abc, deadalnix, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3094

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on May 24 2019, 16:34
markblundebergPushed on May 24 2019, 16:47
Reviewer
Restricted Project
Differential Revision
D3094: [qa] don't pad transactions during make_conform_to_ctor
Parents
rABC13c0b0619074: Add a test to ensure memory isn't consumed for blocks pre-checkpoint
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCa335fc174906: [qa] don't pad transactions during make_conform_to_ctor (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).May 24 2019, 16:47