Page MenuHomePhabricator

[qa] fix abc-p2p-fullblock test to support magnetic anomaly
ClosedPublic

Authored by jasonbcox on Sun, Nov 18, 09:26.

Details

Summary

Fix failures due to >100 byte tx size requirement, and CTOR.

Test Plan
./test/functional/test_runner.py abc-p2p-fullblocktest

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Sun, Nov 18, 09:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Nov 18, 09:26
Fabien requested changes to this revision.Sun, Nov 18, 10:26
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc-p2p-fullblocktest.py
254 ↗(On Diff #5881)

Please remove

This revision now requires changes to proceed.Sun, Nov 18, 10:26
deadalnix added inline comments.
test/functional/abc-p2p-fullblocktest.py
164 ↗(On Diff #5881)

If you need a comment, it means that the function name is not very clear.

make_conform_to_ctor(block)
jasonbcox commandeered this revision.Sun, Nov 18, 17:20
jasonbcox added a reviewer: schancel.
jasonbcox updated this revision to Diff 5888.Sun, Nov 18, 17:20

According to feedback

deadalnix accepted this revision.Sun, Nov 18, 17:27
deadalnix added inline comments.
test/functional/abc-p2p-fullblocktest.py
164 ↗(On Diff #5888)

Put it just before the merkle root hash computation.

jasonbcox updated this revision to Diff 5889.Sun, Nov 18, 17:35

Feedback + make_conform_to_ctor from D2085

jasonbcox edited the summary of this revision. (Show Details)Sun, Nov 18, 17:35
jasonbcox marked 2 inline comments as done.
jasonbcox removed a reviewer: Fabien.
This revision is now accepted and ready to land.Sun, Nov 18, 17:36
deadalnix accepted this revision.Sun, Nov 18, 17:37
This revision was automatically updated to reflect the committed changes.