[backport#16129] Make reasoning about dependencies easier by not including…
a66c80017899
Actions

Description

[backport#16129] Make reasoning about dependencies easier by not including unused dependencies

Summary:
https://github.com/bitcoin/bitcoin/pull/16129/commits/eca97676737174ac6ff775c60e3798c69fb67f4a

Backport of Core PR16129

Test Plan:

ninja
ninja check-all
cd ..
./test/lint/lint-circular-dependencies.sh

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6330

Details

Provenance

practicalswift <practicalswift@users.noreply.github.com>	Authored on Jun 1 2019, 12:25
majcosta	Committed on Jun 2 2020, 21:12
majcosta	Pushed on Jun 2 2020, 21:12

Reviewer

Restricted Project

Differential Revision

D6330: [backport#16129] Make reasoning about dependencies easier by not including unused dependencies

Parents

rABC47de8cc58f9c: [backport#15139] util: Make ToLower and ToUpper take a char

Branches

Unknown

Tags

Unknown

Event Timeline

majcosta committed rABCa66c80017899: [backport#16129] Make reasoning about dependencies easier by not including… (authored by practicalswift <practicalswift@users.noreply.github.com>).Jun 2 2020, 21:12

majcosta added an edge: D6330: [backport#16129] Make reasoning about dependencies easier by not including unused dependencies.

Changes (84)

Path

Size

src/

bench/

consensus/

crypto/

interfaces/

policy/

primitives/

qt/

addresstablemodel.cpp

coincontroldialog.cpp

peertablemodel.cpp

platformstyle.cpp

receivecoinsdialog.cpp

test/

transactionrecord.cpp

transactiontablemodel.cpp

utilitydialog.cpp

walletmodeltransaction.cpp

rpc/

rawtransaction_util.cpp

script/

test/

denialofservice_tests.cpp

multisig_tests.cpp

rpc_tests.cpp

script_p2sh_tests.cpp

util/

validationinterface.cpp

wallet/

test/

wallet_test_fixture.cpp

wallet.cpp

wallettool.cpp

zmq/

zmqabstractnotifier.cpp

zmqnotificationinterface.cpp

test/

lint/

lint-circular-dependencies.sh

rABCa66c80017899

View Options

src/addrman.cpp

View Options

src/arith_uint256.cpp

View Options

src/bench/base58.cpp

View Options

src/bench/bench_bitcoin.cpp

View Options

src/bench/checkqueue.cpp

View Options

src/bench/crypto_hash.cpp

View Options

src/bench/duplicate_inputs.cpp

View Options

src/bench/examples.cpp

View Options

src/bench/rpc_mempool.cpp

View Options

src/bench/wallet_balance.cpp

View Options

src/bitcoin-wallet.cpp

View Options

src/bitcoind.cpp

View Options

src/consensus/merkle.cpp

View Options

src/core_read.cpp

View Options

src/core_write.cpp

View Options

src/crypto/aes.cpp

View Options

src/crypto/sha256_avx2.cpp

View Options

src/crypto/sha256_sse41.cpp

View Options

src/httprpc.cpp

View Options

src/init.cpp

View Options

src/interfaces/node.cpp

View Options

src/interfaces/wallet.cpp

View Options

src/key.cpp

View Options

src/merkleblock.cpp

View Options

src/miner.cpp

View Options

src/net_processing.cpp

View Options

src/netbase.cpp

View Options

src/policy/policy.cpp

View Options

src/primitives/block.cpp

View Options

src/psbt.cpp

View Options

src/qt/addressbookpage.cpp

View Options

src/qt/addresstablemodel.cpp

View Options

src/qt/bantablemodel.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoinunits.cpp

View Options

src/qt/clientmodel.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/qt/platformstyle.cpp

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/test/addressbooktests.cpp

View Options

src/qt/test/apptests.cpp

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/transactiontablemodel.cpp

View Options

src/qt/utilitydialog.cpp

View Options

src/qt/walletmodeltransaction.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/protocol.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/server.cpp

View Options

src/script/script.cpp

View Options

src/script/sigcache.cpp

View Options

src/script/standard.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/torcontrol_tests.cpp

View Options

src/test/txindex_tests.cpp

View Options

src/timedata.cpp

View Options

src/txdb.cpp

View Options

src/txmempool.cpp

View Options

src/ui_interface.cpp

View Options

src/util/system.cpp

View Options

src/validationinterface.cpp

View Options

src/wallet/db.cpp

View Options

src/wallet/fees.cpp

View Options

src/wallet/init.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/init_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.cpp

View Options

src/wallet/wallet.cpp

View Options

src/wallet/wallettool.cpp

View Options

src/zmq/zmqabstractnotifier.cpp

View Options

src/zmq/zmqnotificationinterface.cpp

View Options

test/lint/lint-circular-dependencies.sh

[backport#16129] Make reasoning about dependencies easier by not including…a66c80017899Actions

Description

Details

Event Timeline

Changes (84)

rABCa66c80017899

src/addrman.cpp

src/arith_uint256.cpp

src/bench/base58.cpp

src/bench/bench_bitcoin.cpp

src/bench/checkqueue.cpp

src/bench/crypto_hash.cpp

src/bench/duplicate_inputs.cpp

src/bench/examples.cpp

src/bench/rpc_mempool.cpp

src/bench/wallet_balance.cpp

src/bitcoin-wallet.cpp

src/bitcoind.cpp

src/consensus/merkle.cpp

src/core_read.cpp

src/core_write.cpp

src/crypto/aes.cpp

src/crypto/sha256_avx2.cpp

src/crypto/sha256_sse41.cpp

src/httprpc.cpp

src/init.cpp

src/interfaces/node.cpp

src/interfaces/wallet.cpp

src/key.cpp

src/merkleblock.cpp

src/miner.cpp

src/net_processing.cpp

src/netbase.cpp

src/policy/policy.cpp

src/primitives/block.cpp

src/psbt.cpp

src/qt/addressbookpage.cpp

src/qt/addresstablemodel.cpp

src/qt/bantablemodel.cpp

src/qt/bitcoin.cpp

src/qt/bitcoinunits.cpp

src/qt/clientmodel.cpp

src/qt/coincontroldialog.cpp

src/qt/peertablemodel.cpp

src/qt/platformstyle.cpp

src/qt/receivecoinsdialog.cpp

src/qt/test/addressbooktests.cpp

src/qt/test/apptests.cpp

src/qt/test/rpcnestedtests.cpp

src/qt/test/wallettests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/transactiontablemodel.cpp

src/qt/utilitydialog.cpp

src/qt/walletmodeltransaction.cpp

src/rpc/blockchain.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/protocol.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/server.cpp

src/script/script.cpp

src/script/sigcache.cpp

src/script/standard.cpp

src/test/coins_tests.cpp

src/test/denialofservice_tests.cpp

src/test/multisig_tests.cpp

src/test/rpc_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/torcontrol_tests.cpp

src/test/txindex_tests.cpp

src/timedata.cpp

src/txdb.cpp

src/txmempool.cpp

src/ui_interface.cpp

src/util/system.cpp

src/validationinterface.cpp

src/wallet/db.cpp

src/wallet/fees.cpp

[backport#16129] Make reasoning about dependencies easier by not including…
a66c80017899
Actions